Mute expected error: BLOCK_BY_CONSENT #15903
Conversation
src/error.js
Outdated
| @@ -550,7 +552,7 @@ export function resetAccumulatedErrorMessagesForTesting() { | |||
| * @visibleForTesting | |||
| */ | |||
| export function detectJsEngineFromStack() { | |||
| /** @constructor */ | |||
| /** @class */ | |||
There was a problem hiding this comment.
was trying to make linter happy. But type check doesn't like the change. I added // eslint-disable-line instead.
cc @rsimha
There was a problem hiding this comment.
If closure compiler prefers @constructor over @class, we can specify that preference here.
Lines 39 to 43 in cbf3929
There might be other places where we'd need to change the tag, but it should be a simple find replace, I'd imagine. You needn't include those fixes in this PR. They can be done separately.
There was a problem hiding this comment.
Correct, it does prefer @constructor: https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#constructor
You can add this line to .eslintrc under tagNamePreference:
"class": "constructor",
There was a problem hiding this comment.
Thanks for the investigation.
I've created #15941. Will have a separate PR to fix this.
|
PTAL : ) |
Fix #15871