[amp-story-bookend] Replaces amp images to regular images in amp-story-bookend #15904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
changed the title
gmajoulet
reviewed
Jun 7, 2018
examples/amp-story/bookendv1.json
Outdated
| @@ -15,19 +15,19 @@ | |||
| "type": "small", | |||
| "title": "This is an example article", | |||
| "url": "http://example.com/article.html", | |||
| "image": "http://placehold.it/256x128" | |||
| "image": "http://placehold.it/100x100" | |||
There was a problem hiding this comment.
I liked the idea of having images that don't fit their container, it makes it easier to notice any cropping issue.
|
|
||
| addAttributesToElement(ampImg, dict({'src': articleData.image})); | ||
| el.insertBefore(ampImg, el.firstChild); | ||
| <div class="i-amphtml-story-bookend-article-image"> |
There was a problem hiding this comment.
Here and in the other templates: Can we get rid of this (unnecessary?) div?
There was a problem hiding this comment.
We need it make the images take the full width and height of its available space. Also to do the padding-bottom css trick on the portrait and landscape cards to keep a width and expand/decrease the height.
gmajoulet
approved these changes
Jun 7, 2018
|
@newmuis PTAL |
newmuis
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15313