Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the desktop system layer alignment. #16022

Merged
merged 1 commit into from Jun 13, 2018
Merged

Fixing the desktop system layer alignment. #16022

merged 1 commit into from Jun 13, 2018

Conversation

gmajoulet
Copy link
Contributor

@gmajoulet gmajoulet commented Jun 13, 2018 •
edited

Fixing the desktop system layer alignment:

  • Sound icon vertical alignment before / after
  • No icons alignment before / after
  • Bonus: will work with multiple icons

Fixes #15349

@gmajoulet gmajoulet requested review from newmuis and Enriqe June 13, 2018 19:01
Enriqe
Enriqe approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@Enriqe Enriqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@gmajoulet gmajoulet merged commit a492b48 into ampproject:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newmuis newmuis newmuis approved these changes

@Enriqe Enriqe Enriqe approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gmajoulet @newmuis @Enriqe @googlebot