Start sending EID on canonical doubleclick fast fetch traffic again. #16077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfrizzell
force-pushed
the
frizz-fix-eids
branch
from
d1b428a
to
2622944
Compare
This was referenced Jun 15, 2018
keithwrightbos
requested changes
Jun 15, 2018
| /** | ||
| * Adds the canonical fast experiment ID to the expId array. | ||
| */ | ||
| setCanonicalExperiment() { |
There was a problem hiding this comment.
Why not do this within setPageLevelExperiments?
keithwrightbos
approved these changes
Jun 15, 2018
adelinamart
pushed a commit
that referenced
this pull request
Jun 15, 2018
…16077) * Fix invalid origin bug * Feedback * Fix new lint error
zhouyx
pushed a commit
that referenced
this pull request
Jun 19, 2018
…16077) * Fix invalid origin bug * Feedback * Fix new lint error
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR broke this