Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️✨Clean up autoplay interaction mask creation + a11y #16177

Merged
merged 4 commits into from Jun 20, 2018
Merged

♻️✨Clean up autoplay interaction mask creation + a11y #16177

merged 4 commits into from Jun 20, 2018

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco commented Jun 20, 2018 •
edited

  1. Sets role=button for a11y.
  2. Uses common render functions for autoplay mask + icon.

Closes #12480

@alanorozco alanorozco requested a review from cvializ June 20, 2018 16:26
cvializ
cvializ approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/service/video-manager-impl.js
* @private
* @return {!Element}
*/
createAutoplayAnimation_() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️✂️✂️nice ✂️✂️✂️

@alanorozco alanorozco merged commit b08f1f6 into ampproject:master Jun 20, 2018
@alanorozco alanorozco deleted the role branch June 20, 2018 17:58
@alanorozco alanorozco mentioned this pull request Jun 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvializ cvializ cvializ approved these changes

Assignees

@cvializ cvializ

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanorozco @cvializ @googlebot