Fix flakes by swapping setInterval with setTimeout #16194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm, what is the root cause of |
|
I can only intermittently repro on the Windows Chrome platform because it's flaky : / |
cathyxz
reviewed
Jun 20, 2018
| return poll(`wait for attribute ${attribute} on ${element.tagName}`, () => { | ||
| return element.getAttribute(attribute); | ||
| }, undefined, 8000); | ||
| function waitForAttribute(sandbox, element, attribute) { |
There was a problem hiding this comment.
Since it's an integration test, I don't know if we want a stub...
cvializ
force-pushed
the
unskip/dp-integration
branch
from
68ef479
to
5446958
Compare
cvializ
changed the title
|
@cathyxz @aghassemi PTAL : ) |
|
Flaking on master : ( |
cvializ
added a commit
that referenced
this pull request
Jun 22, 2018
* Revert "Shows hint overlay on up swipe like version 1.0 (#16258)" This reverts commit 56566b4. * Revert "Validator rollup (#16266)" This reverts commit 66d09a2. * Revert "throws error when using invalid component type in the config. (#16231)" This reverts commit 3693815. * Revert "Get rid of isRelayoutNeeded and refactor to onMeasureChanged (#16259)" This reverts commit 18c1db9. * Revert "Fix amp-pan-zoom zoom target bug and relayout bug (#16257)" This reverts commit 5d6d391. * Revert "Fix flakes by swapping setInterval with setTimeout (#16194)" This reverts commit 53de1af.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16179