Fix for resource#resolveDeferredsWhenWithinViewports_ to use parseFloat #16238
Conversation
src/service/resource.js
Outdated
| delete this.withViewportDeferreds_[viewportInt]; | ||
| const viewportNum = dev().assertNumber(parseFloat(keys[i], 10)); | ||
| if (this.isWithinViewportRatio(viewportNum, viewportRatio)) { | ||
| this.withViewportDeferreds_[viewportNum].resolve(); |
There was a problem hiding this comment.
I thought the fix was to check if this.withViewportDeferreds_[viewportNum] is defined.
src/service/resource.js
Outdated
| if (this.isWithinViewportRatio(viewportInt, viewportRatio)) { | ||
| this.withViewportDeferreds_[viewportInt].resolve(); | ||
| delete this.withViewportDeferreds_[viewportInt]; | ||
| const viewportNum = dev().assertNumber(parseFloat(keys[i], 10)); |
There was a problem hiding this comment.
parseFloat(1.25, 10) = 1.25, which leads to this.withViewportDeferreds_[1.25]. I think we should keep using parseInt
There was a problem hiding this comment.
nvm, just learnt that the key here is a string, where we are expecting this.withViewportDeferreds_['1.25']
src/service/resource.js
Outdated
| if (this.isWithinViewportRatio(viewportInt, viewportRatio)) { | ||
| this.withViewportDeferreds_[viewportInt].resolve(); | ||
| delete this.withViewportDeferreds_[viewportInt]; | ||
| const viewportNum = dev().assertNumber(parseFloat(keys[i], 10)); |
There was a problem hiding this comment.
nvm, just learnt that the key here is a string, where we are expecting this.withViewportDeferreds_['1.25']
| // used as numbers in isWithinViewportRatio. | ||
| const viewportNum = dev().assertNumber(parseFloat(keys[i])); | ||
| if (this.isWithinViewportRatio(viewportNum, viewportRatio)) { | ||
| this.withViewportDeferreds_[viewportNum].resolve(); |
There was a problem hiding this comment.
When I do so, I get ERROR - restricted index type
found : string
required: number
Casting via /** @type {number} */(keys[i]) doesn't help
…at (#16238) * initial commit * add comment * Fix type check error
Fix for #16218