🐛Fix broken test for postmessage origin in amp-brightcove #16361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mister-ben
changed the title
alanorozco
approved these changes
Jul 24, 2018
|
Merging this since it was approved. |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…#16361) * Fix broken test for postmessage origin * add amp-brightcove to amp-analytics video support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor in #15527 breaks the test for the postmessage source in amp-brightcove. Instead of matching if the message source is the player iframe and the origin is as expected, [it now erroneously matches only if the origin is anything other than what is expected].(5c6f199#diff-4d51c1b168f56d58518c97a3115effddL159).
This changes the test to checking whether the source is the component's frame. The origin check is superfluous.
Also adds amp-brightcove to the documentation for video analytics support, as this will work with this fix.