Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 fix nested html issue. #16373

Merged
merged 2 commits into from Jun 26, 2018
Merged

馃悰 fix nested html issue. #16373

merged 2 commits into from Jun 26, 2018

Conversation

jpettitt
Copy link
Contributor

fixes #16370

cramforce
cramforce approved these changes Jun 26, 2018
View reviewed changes
Copy link
Member

@cramforce cramforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue for a presubmit test that catches such selectors.

@prateekbh
Copy link
Member

amp-subscriptions renderer needs some changes

@jpettitt jpettitt mentioned this pull request Jun 26, 2018
Closed
@dvoytenko dvoytenko merged commit 08945dd into ampproject:master Jun 26, 2018
jridgewell pushed a commit that referenced this pull request Jun 26, 2018
@jpettitt @jridgewell
馃悰 fix nested html issue. (#16373)
059728d 
* fix nested html issue.

* tests fix
@jpettitt jpettitt deleted the subs-viewer-fix branch June 26, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cramforce cramforce cramforce approved these changes

@prateekbh prateekbh prateekbh approved these changes

@dvoytenko dvoytenko Awaiting requested review from dvoytenko

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

double html elements breaking amp-subscriptions CSS on iPhone with viewer
5 participants
@jpettitt @prateekbh @cramforce @dvoytenko @googlebot