馃摉 amp-app-banner: Warn on missing app-argument. #16405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the '<meta name="apple-itunes-app">' is missing app-argument in the content attribute, then the app will not open as expected if already installed. Instead, the user will be taken to the app store. Add a console error so that developers are aware of this.
aghassemi
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the '' is missing app-argument in the
content attribute, then the app will not open as expected if already
installed. Instead, the user will be taken to the app store.
Add a console error so that developers are aware of this.
Context: #15006 (comment). Found that several sites are missing this and as a result, the open in app button is not working correctly.
/cc @aghassemi