URL rewrite in templates #1645
Merged
URL rewrite in templates #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
force-pushed
the
templ-urlrepl
branch
from
c7e4363
to
8377a9d
Compare
| * Reconstructs the string expression for this srcset. | ||
| * @return {string} | ||
| */ | ||
| stringify() { |
There was a problem hiding this comment.
This would generally be called #toString, so that coercion will work correctly:
var obj = {
toString() { return 'test'; }
};
String(obj); // => 'test'
'' + obj; // => 'test'There was a problem hiding this comment.
I don't really like coercion to be honest. Usually I try to steer away. You feel strongly about it, I'll switch.
|
@cramforce changes have been made. PTAL. |
dvoytenko
force-pushed
the
templ-urlrepl
branch
from
7f6ab57
to
1219698
Compare
|
@cramforce freundlich Ping! |
| function resolveImageUrlAttr(attrValue, baseUrl, isProxy) { | ||
| const src = parseUrl(resolveRelativeUrl(attrValue, baseUrl)); | ||
|
|
||
| // URLs such as `data:` or proxy URLs are returned as is. |
There was a problem hiding this comment.
Need to document here why this is safe.
There was a problem hiding this comment.
Ok. I made it explicit to data:
|
LGTM with one comment. If the comment is correct. Otherwise not LGTM :) |
dvoytenko
force-pushed
the
templ-urlrepl
branch
from
1219698
to
1e7bb39
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.