Amp-ad-exit / amp-analytics transport frame integration improperly referencing win.top #16587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferencing win.top
bradfrizzell
reviewed
Jul 6, 2018
| @@ -314,7 +315,7 @@ export class AmpAdExit extends AMP.BaseElement { | |||
| * @private | |||
| */ | |||
| getAmpAdResourceId_() { | |||
| return getAmpAdResourceId(this.element, this.win.top); | |||
| return getAmpAdResourceId(this.element, getTopWindow(this.win)); | |||
Codecov Report
@@ Coverage Diff @@
## master #16587 +/- ##
==========================================
+ Coverage 78.06% 78.07% +0.01%
==========================================
Files 551 551
Lines 40318 40318
==========================================
+ Hits 31474 31480 +6
+ Misses 8844 8838 -6
Continue to review full report at Codecov.
|
bradfrizzell
suggested changes
Jul 6, 2018
|
|
||
| it('getAmpAdResourceId_ should reference AMP top window', () => { | ||
| const frame = win.document.createElement('iframe'); | ||
| win.document.body. appendChild(frame); |
There was a problem hiding this comment.
nit: remove space in between body. and appendChild
bradfrizzell
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causes breakage when AMP page is not at window.top (e.g. when within the viewer). Fix is to reference src/service#getTopWindow