Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Lint: isExperimentOn must be passed an explicit string #16688

Merged
merged 2 commits into from Jul 12, 2018
Merged

馃彈 Lint: isExperimentOn must be passed an explicit string #16688

merged 2 commits into from Jul 12, 2018

Commits on Jul 12, 2018

  1. Lint: isExperimentOn must be passed an explicit string 

    The root cause of ampproject#16671 (from ampproject#16528) is difficutly grepping for used experiment flags.

So, make them very grepable.

```js
// BAD
const EXP = 'experiment-name';
isExperimentOn(win, EXP);

// GOOD
isExperimentOn(win, 'experiment-name');
    @jridgewell
    jridgewell committed Jul 12, 2018
    Copy the full SHA
    b1d401e View commit details
    Browse the repository at this point in the history

  2. Fix remaining MULTI_CONSENT_EXPERIMENT usages

    @jridgewell
    jridgewell committed Jul 12, 2018
    Copy the full SHA
    c480e3d View commit details
    Browse the repository at this point in the history