-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provides support for amp-ad type=plista #1669
Conversation
Thanks, @torbenbrodt! Assigning to @cramforce for review. |
useDocumentReady: false, | ||
dataMode: 'data-display' | ||
}; | ||
s = d.createElement(n); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use loadScript
from '../src/3p'
to request the URL
Looks great, thanks! A few comments. |
*/ | ||
export function plista(global, data) { | ||
checkData(data, ['publickey', 'widgetname']); | ||
let s, g; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style nit: Please declare vars as late as possible, do not use , with let
and const
.
thx a lot for your feedback, which I really appreciate. I think we got all changes implemented. Tests are green. |
LGTM. Please rebase and squash commits and this is good to go. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
build failed because of timeout on ubuntu APT servers
can you please run travis again? |
LGTM. Merging. |
Provides support for amp-ad type=plista
Provides support for amp-ad type=plista
Contributor License Agreement (CLA) was signed