Adds support for AT Internet #1672

BenDz · 2016-01-29T14:52:00Z

This request adds support for AT Internet solution as a vendor.

Tagging example:

<amp-analytics id="atinternet">
    <script type="application/json">
        {
            "vars": {
                "site": "123456",
                "log": "logs",
                "domain": ".xiti.com",
                "title": "pageChapter::pageTitle",
                "level2": "10"
            },
            "triggers": {
                "defaultPageview": {
                    "on": "visible",
                    "request": "pageview"
                },
                "links": {
                    "on": "click",
                    "selector": "a",
                    "request": "click",
                    "vars": {
                        "label": "clickChapter::clickLabel",
                        "level2Click": "12",
                        "type": "a"
                    }
                }
            }
        }
    </script>
</amp-analytics>

Our own documentation for integration is being written.

googlebot · 2016-01-29T14:52:04Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

cramforce · 2016-01-29T15:27:00Z

Thanks for the pull request! Handing over to @avimehta and @rudygalfi

rudygalfi · 2016-01-29T17:27:48Z

extensions/amp-analytics/0.1/vendors.js

@@ -79,5 +79,22 @@ export const ANALYTICS_CONFIG = {
    },
    'optout': '_gaUserPrefs.ioo'
  }
+
+  'atinternet': {


I'd suggest sequencing this above googleanalytics above to keep things alphabetically organized.

avimehta · 2016-02-03T15:32:50Z

Please sign the cla and reply to this thread with "I signed it!".

Also, please add an example of how to use the new type in examples/analytics.amp.html

Once that is done, Also, please squash the commits into a single commit and rebase to head as there are a few changes to the files you are submitting...

Thanks for the PR!

BenDz · 2016-02-05T10:53:06Z

Signature is in progress, it will be for the corporation AT Internet.

avimehta · 2016-02-05T14:29:57Z

Ben: will look at the commit later today. Thanks For the update!

Also starts mandating AMP CORS protocol for credentialed requests to amp-list. Verified that the guardian is currently not including credentials in their requests.

Adding Smart AdServer support

Enable retrieving amp-analytics remote config with credentials.

Access: require CORS/AMP authorization

Normal layout can be a bit delayed.

Make sure we re-show visible ads as fast as possible.

- Avoid using the return value of addPositionTo (which is Token, not ErrorToken) - Assert that the elements returned by querySelectorAll are HTMLElement instances.

Create new UrlSpec usable by AttrSpec for allowed protocols in href/src attributes. Validate URLs are not missing Validate URLs are valid (via goog.Uri.parse) Validate protocols are allowed for certain tags Add colon to Entities list for htmlparser. Fix lookupEntity_ in htmlparser to actually look up the entity by name. anchor's href: http, https, mailto, sms, whatsapp, viber img's src: http, https amp-audio > source's src: http, https amp-video > source's src: https audio > source's src: http, https video > source's src: https amp-img's src: data, http, https amp-anim's src: data, http, https amp-video's src: https amp-ad's src: https amp-embed's src: https amp-youtube's src: https amp-twitter's src: https amp-instagram's src: https amp-iframe's src: https amp-pixel's src: https amp-audio's src: http, https amp-list's src: https amp-install-serviceworker's src: https

sync with the published spec.

Github #1847

update gulp to shut up the warnings

Validation roll-up

Loading indicator for amp-embed

Also filters out changes that happen in the same milli seconds. Deletes the `amp-iframe` intersection tests because they are super bad and I already filed #1822 to rewrite them.

This is better than local, but ideally this would point at the right tag.

Reference sourcemaps from GitHub.

Throttle intersection observer posts to 10 per second.

Cache URL parsing results.

BenDz · 2016-02-10T07:34:14Z

Hi @rudygalfi - I was OoO yesterday, will check it today and squash the commits to a single one.
Thanks!

googlebot · 2016-02-10T07:34:16Z

CLAs look good, thanks!

Example fixed

googlebot · 2016-02-10T13:01:54Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

BenDz · 2016-02-10T15:57:57Z

Hi, I created a new clean PR for this integration. Please check #1908.
Thanks!

rudygalfi · 2016-02-10T16:38:31Z

Closing to move over to #1908

BenDz added 2 commits January 29, 2016 15:43

AT Internet vendor addition

2d7a202

AT Internet type added

40b3b3a

cramforce assigned avimehta Jan 29, 2016

cramforce added the WG: analytics label Jan 29, 2016

rudygalfi reviewed Jan 29, 2016
View reviewed changes

BenDz added 2 commits February 3, 2016 10:12

Alphabetical order + explicit image transport

27397b5

Alphabetical order

b79ffb0

BenDz added 2 commits February 3, 2016 17:40

AT Internet vendor addition

321104d

Alphabetical order + explicit image transport

0b611ff

rudygalfi added the NEEDS REVIEW label Feb 3, 2016

Jordan M Adler and others added 5 commits February 4, 2016 08:36

Add dateModified to Recipes samples

62f2090

Access: require CORS/AMP authorization

8b63778

Merge remote-tracking branch 'origin/master'

daf3d89

Integrating Avi's feedbacks

1af0f26

Merge commit

3a08bbb

Example fixed

92b0505

Sebastien F and others added 8 commits February 5, 2016 16:45

Adding Smart AdServer support

f86f6ec

Enable retrieving amp-analytics remote config with credentials.

fe5f740

Also starts mandating AMP CORS protocol for credentialed requests to amp-list. Verified that the guardian is currently not including credentials in their requests.

Merge pull request #1808 from sebastienferry/master

f5cd1b6

Adding Smart AdServer support

Merge pull request #1805 from cramforce/analytics-config

64b20ba

Enable retrieving amp-analytics remote config with credentials.

Merge pull request #1800 from dvoytenko/access31

5536b9a

Access: require CORS/AMP authorization

Clarify display:none behavior

9ee7c99

Make sure we re-show visible ads as fast as possible.

896a4d6

Normal layout can be a bit delayed.

Merge pull request #1811 from cramforce/ad-show

d96a38d

Make sure we re-show visible ads as fast as possible.

powdercloud and others added 16 commits February 9, 2016 14:16

Move the logic for the data- attrs into its own method.

11ec8f9

Fix two closure compilation warnings.

1a08ef6

- Avoid using the return value of addPositionTo (which is Token, not ErrorToken) - Assert that the elements returned by querySelectorAll are HTMLElement instances.

Add a few more required fields to <amp-user-notification> tag to stay in

ad9f64e

sync with the published spec.

Add support for wordpress rel=attachment syntax.

927b0c3

Github #1847

Reverse change to <amp-user-notification>. The spec was out of date.

451f746

Merge pull request #1878 from erwinmombay/gulp-update

2a8e186

update gulp to shut up the warnings

Loading indicator for amp-embed

919ba58

Merge pull request #1879 from Gregable/validation

90b2580

Validation roll-up

Merge pull request #1880 from dvoytenko/fixes38

8a4d528

Loading indicator for amp-embed

Throttle intersection observer posts to 10 per second.

c6031c6

Also filters out changes that happen in the same milli seconds. Deletes the `amp-iframe` intersection tests because they are super bad and I already filed #1822 to rewrite them.

Cache URL parsing results.

d283c8f

Reference sourcemaps from GitHub.

d804ad3

This is better than local, but ideally this would point at the right tag.

Merge pull request #1887 from cramforce/sourcemaps-github

3c3ee09

Reference sourcemaps from GitHub.

Merge pull request #1889 from cramforce/throttle-intersection-observer

5cde679

Throttle intersection observer posts to 10 per second.

Merge pull request #1893 from cramforce/url-perf

1b25397

Cache URL parsing results.

BenDz added 3 commits February 10, 2016 13:31

Merge commit

10cf661

Example fixed

AT Internet vendor addition

563a9be

Add support for AT Internet

951bc91

BenDz added 4 commits February 10, 2016 14:02

Add support for AT Internet

36af550

Merge remote-tracking branch 'origin/master'

d574f13

AT Internet vendor addition

62b4328

AT Internet vendor addition

7c458f9

rudygalfi closed this Feb 10, 2016

henel677 mentioned this pull request May 12, 2021

SwG release 0.1.22.165 #34352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds support for AT Internet #1672

Adds support for AT Internet #1672

BenDz commented Jan 29, 2016

googlebot commented Jan 29, 2016

cramforce commented Jan 29, 2016

rudygalfi Jan 29, 2016

avimehta commented Feb 3, 2016

BenDz commented Feb 5, 2016

avimehta commented Feb 5, 2016

BenDz commented Feb 10, 2016

googlebot commented Feb 10, 2016

googlebot commented Feb 10, 2016

BenDz commented Feb 10, 2016

rudygalfi commented Feb 10, 2016

Adds support for AT Internet #1672

Adds support for AT Internet #1672

Conversation

BenDz commented Jan 29, 2016

googlebot commented Jan 29, 2016

cramforce commented Jan 29, 2016

rudygalfi Jan 29, 2016

Choose a reason for hiding this comment

avimehta commented Feb 3, 2016

BenDz commented Feb 5, 2016

avimehta commented Feb 5, 2016

BenDz commented Feb 10, 2016

googlebot commented Feb 10, 2016

googlebot commented Feb 10, 2016

BenDz commented Feb 10, 2016

rudygalfi commented Feb 10, 2016