User notifications with local storage docs #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,6 +119,9 @@ will be passed in future requests to data-show-if-href) | |||
| ``` | |||
| - `POST response` should be a 200 HTTP code and no data is expected back. | |||
|
|
|||
| If not specified, AMP will only not send a request upon dismissal and will only store "dismissed" | |||
There was a problem hiding this comment.
is this right, "will only not" ?
|
@dvoytenko LGTM |
|
@Meggin PTAL. This is coming very soon. |
|
Thanks for heads up. Can I update validation content to reflect this? If it's really soon, should be safe to do so, as we can hold off on pushing updates to doc server a day. |
|
My estimate is that it will launch this Thursday or Friday at the latest. |
|
Perfect. Seems smart in my next rounds of edits to reflect these changes On Tue, Feb 9, 2016 at 11:36 AM, Dima Voytenko notifications@github.com
|
dvoytenko
added a commit
that referenced
this pull request
Feb 10, 2016
User notifications with local storage docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will defer the merge for a bit, but please review when you can.