Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗🐛 Move negative lint globs to .eslintignore #16759

Merged
merged 1 commit into from Jul 16, 2018
Merged

🏗🐛 Move negative lint globs to .eslintignore #16759

merged 1 commit into from Jul 16, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jul 16, 2018

This makes it so that the eslint plugin of VS Code no longer complains about errors in files that shouldn't be linted in the first place.

Fixes #16752

@rsimha rsimha self-assigned this Jul 16, 2018
@rsimha rsimha requested a review from dparikh July 16, 2018 21:46
@rsimha
Copy link
Contributor Author

rsimha commented Jul 16, 2018

/to @dparikh

Copy link
Contributor

@dparikh dparikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Raghu.

@codecov-io
Copy link

codecov-io commented Jul 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0a14321). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #16759   +/-   ##
=========================================
  Coverage          ?   78.03%           
=========================================
  Files             ?      557           
  Lines             ?    40416           
  Branches          ?        0           
=========================================
  Hits              ?    31538           
  Misses            ?     8878           
  Partials          ?        0
Flag Coverage Δ
#integration_tests 34.9% <ø> (?)
#unit_tests 77.06% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a14321...fc6d4fa. Read the comment docs.

@rsimha rsimha merged commit ad11743 into ampproject:master Jul 16, 2018
@rsimha rsimha deleted the 2018-07-16-LintGlobs branch July 16, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants