Fix amp-state mutation bug when opening new tab #16772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alabiaga
approved these changes
Jul 17, 2018
mahmoud200m
approved these changes
Jul 17, 2018
Codecov Report
@@ Coverage Diff @@
## master #16772 +/- ##
==========================================
- Coverage 78.06% 77.09% -0.97%
==========================================
Files 558 557 -1
Lines 40440 40383 -57
==========================================
- Hits 31569 31134 -435
- Misses 8871 9249 +378
Continue to review full report at Codecov.
|
|
Tested manually that this fixes repro case on the bug. |
gopanisandip
pushed a commit
to gopanisandip/amphtml
that referenced
this pull request
Jul 27, 2018
* Check viewer hasBeenVisible instead of isVisible to support opening tabs. * Fix other tests. * Fix tests for real.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15450.
/to @alabiaga