馃摉 Clean up wording in doc #16787
Merged
馃摉 Clean up wording in doc #16787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
cathyxz
approved these changes
Jul 17, 2018
cathyxz
reviewed
Jul 17, 2018
| ``` | ||
|
|
||
| ## Attributes | ||
| ##### max-scale (optional) | ||
| Specifies a max zoom scale, otherwise set to 3. | ||
| Specifies a max zoom scale, which can be a value from 0 - 9. The default value is 3. |
There was a problem hiding this comment.
From 1 to 9, not from 0 to 9.
|
Actually I should not have approved this. Sorry--the scale from 0 to 9 is incorrect. It makes no sense to have a zoom scale of 0. The min scale is 1. |
|
I'm about to re-edit it. Checking some of the validator stuff first. |
gopanisandip
pushed a commit
to gopanisandip/amphtml
that referenced
this pull request
Jul 27, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up formatting and wording in spec for
amp-pan-zoom.