🐛 amp-next-page: Fix rendering within shadow documents #16789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `amp-next-page` tries to load in a shadow document, the service gets registered against the AmpDoc rather than the window. Fixes ampproject#16666
peterjosling
force-pushed
the
next-page/shadow-fix
branch
from
8c01cb3
to
a4fb307
Compare
aghassemi
reviewed
Jul 19, 2018
| }); | ||
| this.register_(configJson, separator); | ||
| } | ||
| getServicePromiseForDoc(this.getAmpDoc(), SERVICE_ID).then(service => { |
There was a problem hiding this comment.
Please return the promise to eliminate any possibility of a race between buildCallback and layoutCallback (it is a little know fact that buildCallback can return a promise)
There was a problem hiding this comment.
Oh cool! Done.
aghassemi
approved these changes
Jul 19, 2018
|
@peterjosling Just some unit test failures related to the component. Will merge when green. Thanks! |
|
Done. |
Codecov Report
@@ Coverage Diff @@
## master #16789 +/- ##
==========================================
- Coverage 78.15% 78.14% -0.01%
==========================================
Files 560 561 +1
Lines 40635 40755 +120
==========================================
+ Hits 31757 31847 +90
- Misses 8878 8908 +30
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
amp-next-pagetries to load in a shadow document, the service gets registered against the AmpDoc rather than the window, andgetService()tries to read it from the window.Fixes #16666