Fix regression where polyfills where build into into extensions. #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
polyfills-extensions
branch
from
4818a81
to
d9f5cbc
Compare
| @@ -14,6 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| import './polyfills'; | |||
There was a problem hiding this comment.
Can we remove the import in timers.js?
There was a problem hiding this comment.
We really need a better solution. Basically you need to put it everywhere that uses promises and has an immediate side effect.
cramforce
force-pushed
the
polyfills-extensions
branch
from
d9f5cbc
to
6c9efcc
Compare
|
PTAL |
| // Many files include the polyfills, but we only want to deliver them | ||
| // once. Since all files automatically wait for the main binary to load | ||
| // this works fine. | ||
| if (options.includePolyfills) { |
There was a problem hiding this comment.
I think the conditional is backwards?
There was a problem hiding this comment.
There are two files that resolve to the module name. One is empty. If we should include polyfills, it removes the empty from the set, otherwise it removes the actual file.
|
@cramforce tested, LGTM |
cramforce
added a commit
that referenced
this pull request
Jan 29, 2016
Fix regression where polyfills where build into into extensions.
Gregable
pushed a commit
that referenced
this pull request
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.