Validator roll-up #1682
Merged
Validator roll-up #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both -latest.js and -<version>.js will validate.
This implements #1616 The new "heights" attribute is part of the layout=responsive ecosystem. It's developed in #1331 The rules are very similar to sizes attribute: 1. If layout is not specified and heights attribute is specified - implied layout is responsive 2. heights attribute can only be specified for elements with layout=responsive - input or implied 3. The format of the heights attribute is the same as sizes with a single exception that % are allowed as values (not sure we actually validate content of sizes attribute). Notes: 2.) done, but we don't do this currently for sizes - should we? 3.) n/a we don't validate sizes either.
meaningless tag of the form: <link src="...">
No longer require data-show-if-href and data-dismiss-href. Since they're data- attribs, they're still allowed.
Also clean up some protoascii comments while in here.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@googlebot I confirm. |
1 similar comment
|
@googlebot I confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support -latest.js scripts
Support 'heights' attribute.
Tighten rules around
<link>attributes to improve some error messages.Css parser refactoring.
Actually require
<link rel=canonical ...>and<html amp>Allow hreflang attributes on link tags (#1664)