Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amp-fx to the whitelist of attributes allowed on amp-list templates #16913

Merged
merged 1 commit into from Jul 19, 2018

Conversation

nainar
Copy link
Contributor

@nainar nainar commented Jul 19, 2018

Fixes #16838

@codecov-io
Copy link

Codecov Report

Merging #16913 into master will decrease coverage by 0.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16913      +/-   ##
==========================================
- Coverage   78.13%   77.14%   -0.99%     
==========================================
  Files         560      559       -1     
  Lines       40641    40581      -60     
==========================================
- Hits        31756    31308     -448     
- Misses       8885     9273     +388
Flag Coverage Δ
#integration_tests 12.44% <ø> (-22.09%) ⬇️
#unit_tests 77.14% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f06595...aa3d168. Read the comment docs.

@nainar nainar merged commit b3ef5b8 into ampproject:master Jul 19, 2018
@aghassemi aghassemi added this to PR - merged in FixIt - UI - July 2018 Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
FixIt - UI - July 2018
  
PR - merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants