Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰馃枍 Do not use display: grid for story body #16969

Merged
merged 1 commit into from Jul 20, 2018

Conversation

newmuis
Copy link
Contributor

@newmuis newmuis commented Jul 20, 2018

display: grid was causing the story to split the body equally with any other element(s) contained in the body, such as those added at runtime by browser extensions. Removing this defaults back to display: block which does not have this problem.

Fixes #12140.

@codecov-io
Copy link

Codecov Report

Merging #16969 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16969      +/-   ##
==========================================
- Coverage   78.13%   78.11%   -0.03%     
==========================================
  Files         561      561              
  Lines       40754    40754              
==========================================
- Hits        31844    31834      -10     
- Misses       8910     8920      +10
Flag Coverage 螖
#integration_tests 34.46% <酶> (酶) 猬嗭笍
#unit_tests 77.15% <酶> (-0.04%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1df02b2...3e142dc. Read the comment docs.

@Enriqe Enriqe added this to the Fixit Summit July 2018 milestone Jul 20, 2018
@newmuis newmuis merged commit 1a06042 into ampproject:master Jul 20, 2018
@nainar nainar moved this from PR - in review to PR - merged in FixIt - UI - July 2018 Jul 20, 2018
@aghassemi aghassemi removed this from PR - merged in FixIt - UI - July 2018 Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants