Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with an error code when Karma detects zero tests #16970

Merged
merged 1 commit into from Jul 20, 2018
Merged

Exit with an error code when Karma detects zero tests #16970

merged 1 commit into from Jul 20, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jul 20, 2018

Addresses #16878 (review)

Follow up to #16878
Fixes #16851

@rsimha rsimha self-assigned this Jul 20, 2018
@rsimha
Copy link
Contributor Author

rsimha commented Jul 20, 2018

/to @cramforce @choumx

@codecov-io
Copy link

Codecov Report

Merging #16970 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16970      +/-   ##
==========================================
+ Coverage   78.12%   78.17%   +0.04%     
==========================================
  Files         561      561              
  Lines       40754    40754              
==========================================
+ Hits        31840    31859      +19     
+ Misses       8914     8895      -19
Flag Coverage Δ
#integration_tests 34.5% <ø> (+0.04%) ⬆️
#unit_tests 77.21% <ø> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232a0d2...1bf5eaf. Read the comment docs.

@cramforce cramforce merged commit fb6c2be into ampproject:master Jul 20, 2018
@rsimha rsimha deleted the 2018-07-20-ZeroTestsExit branch July 20, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants