Fixed and unskipped some amp-story tests #16977
Conversation
addieachan
commented
Jul 20, 2018
addieachan
commented
- Fixit Summit July 2018
- Address issue Re-enable skipped tests for amp-story #11639
|
I tried deleting a test that I thought was deprecated (part of system layer and couldn't find method anymore), but I may have done so wrongfully if I just misunderstood it! |
addieachan
changed the title
addieachan
changed the title
| @@ -619,4 +608,4 @@ describes.realWin('amp-story origin whitelist', { | |||
| story.originWhitelist_ = ['example.co']; | |||
| expect(story.isOriginWhitelisted_('https://example.co.uk')).to.be.false; | |||
| }); | |||
| }); | |||
| }); | |||
There was a problem hiding this comment.
Re-add newline at end of file
| expect(pauseOldPageStub).to.have.been.calledOnce; | ||
| expect(resumeNewPageStub).to.have.been.calledOnce; | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| // TODO(#11639): Re-enable this test. |
There was a problem hiding this comment.
could you also remove this comment please?
There was a problem hiding this comment.
I actually haven't figured out that one yet, so I was supposed to skip it as well instead of accidentally enabling it again. Sorry for the confusion! I readded the skip so the comment makes sense
Codecov Report
@@ Coverage Diff @@
## master #16977 +/- ##
==========================================
+ Coverage 78.11% 78.13% +0.02%
==========================================
Files 561 562 +1
Lines 40760 40782 +22
==========================================
+ Hits 31840 31867 +27
+ Misses 8920 8915 -5
Continue to review full report at Codecov.
|
