Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup signin experiment #16983

Merged
merged 4 commits into from Jul 21, 2018
Merged

Cleanup signin experiment #16983

merged 4 commits into from Jul 21, 2018

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Jul 20, 2018 •
edited

Closes #4226.

@dvoytenko dvoytenko requested a review from prateekbh July 20, 2018 19:30
prateekbh
prateekbh approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@prateekbh prateekbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit

extensions/amp-access/0.1/amp-access-source.js Outdated
@@ -488,8 +478,7 @@ export class AccessSource {
} else {
this.loginAnalyticsEvent_(eventLabel, 'rejected');
}
const exchangePromise = this.signIn_.postLoginResult(query) ||
Promise.resolve();
const exchangePromise = Promise.resolve();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov-io
Copy link

codecov-io commented Jul 20, 2018 •
edited

Codecov Report

Merging #16983 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16983      +/-   ##
==========================================
- Coverage   78.05%   78.03%   -0.02%     
==========================================
  Files         563      562       -1     
  Lines       41128    41078      -50     
==========================================
- Hits        32101    32055      -46     
+ Misses       9027     9023       -4
Flag Coverage Δ
#integration_tests 36.17% <ø> (+0.01%) ⬆️
#unit_tests 77.08% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4389e91...3e09289. Read the comment docs.

@dvoytenko dvoytenko merged commit 3e2e760 into ampproject:master Jul 21, 2018
@dvoytenko dvoytenko deleted the access82 branch July 21, 2018 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekbh prateekbh prateekbh approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dvoytenko @codecov-io @prateekbh @googlebot