getImpl returns type BaseElement which doesn't have resetOnChange
#16987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
fix-amp-story-types
branch
from
84960e3
to
bc3a8e3
Compare
alanorozco
approved these changes
Jul 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #16987 +/- ##
==========================================
+ Coverage 77.2% 78.12% +0.92%
==========================================
Files 561 562 +1
Lines 40711 40772 +61
==========================================
+ Hits 31429 31852 +423
+ Misses 9282 8920 -362
Continue to review full report at Codecov.
|
newmuis
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we could also possibly cast this into AmpVideo type