Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅Fix silently failed test-amp-sticky-ad #16997

Merged
merged 2 commits into from Jul 20, 2018

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Jul 20, 2018

Fix #14775
Partial for #16076

@zhouyx zhouyx requested review from cathyxz and lannka July 20, 2018 21:29
@zhouyx zhouyx added this to In Progress in Ads & Analytics Fixit - July 2018 via automation Jul 20, 2018
@zhouyx zhouyx merged commit 13d4468 into ampproject:master Jul 20, 2018
Ads & Analytics Fixit - July 2018 automation moved this from In Progress to Merged PRs Jul 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #16997 into master will increase coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16997      +/-   ##
==========================================
+ Coverage   77.14%   77.96%   +0.81%     
==========================================
  Files         561      563       +2     
  Lines       40729    41467     +738     
==========================================
+ Hits        31422    32331     +909     
+ Misses       9307     9136     -171
Flag Coverage Δ
#integration_tests 36.15% <ø> (?)
#unit_tests 77.02% <ø> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f00e5...d4ee2e6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants