amp-ad type=dotandads implementation #1705
Conversation
|
I think there are some problems with lint. It's returning "TypeError: Cannot read property 'visitClass' of undefined" in Travis Build |
|
Do you see the same error when running |
| <style>body {opacity: 0}</style><noscript><style>body {opacity: 1}</style></noscript> | ||
| </head> | ||
| <body> | ||
| <amp-ad width=980 height=250 |
There was a problem hiding this comment.
Sorry, I missed this before: Please merge this into ads.amp.html. We're trying to keep the count of examples somewhat limited.
There was a problem hiding this comment.
ok, I'll merge them
|
Running lint on a clean branch to check whats up https://travis-ci.org/ampproject/amphtml/builds/106271563 |
|
Yes, I have the same error locally |
|
Confirmed it is not your issue https://travis-ci.org/ampproject/amphtml/builds/106271563 Please address the example-comment above and we can merge this. Thanks! |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
CLAs look good, thanks! |
|
Ok, I've fixed the example and squashed the commits ^^ Thank you |
|
Do we have to make some fixes for the conflicts that the check is showing? |
|
@dotandads You do need to rebase from master, so we can merge your PR. After that the build should also be green. |
added implementation for dotandads type for amp-ad fix merge merge fix fix merge fix merge
|
@cramforce ok, thanks. Everything looks green now |
|
|
||
| ## Configuration | ||
|
|
||
| For semantics of configuration, please see ad network documentation. |
There was a problem hiding this comment.
Maybe in a follow up send a PR with a link, so people know where to look.
|
LGTM. See comment above for a follow up. Merging. |
amp-ad type=dotandads implementation
Provides support for amp-ad type=dotandads