Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Prevent double click on iframe during transition, cleanup test #17090

Merged
merged 23 commits into from
Aug 6, 2018

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco commented Jul 25, 2018

  • Offset FIE by scrolltop since its position is fixed (cleanup test).
  • Prevent re-sending message during transition by setting pointer-events.

@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #17090 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17090      +/-   ##
==========================================
- Coverage   77.88%   77.86%   -0.03%     
==========================================
  Files         562      562              
  Lines       41149    41149              
==========================================
- Hits        32050    32039      -11     
- Misses       9099     9110      +11
Flag Coverage Δ
#integration_tests 36.17% <ø> (+0.03%) ⬆️
#unit_tests 76.9% <ø> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4549f74...889384d. Read the comment docs.

@alanorozco alanorozco changed the title 🐛 Prevent visual jumps when expanding iframe 🐛 Prevent double click on iframe during transition, cleanup test Jul 27, 2018
@alanorozco alanorozco merged commit e0eb99a into ampproject:master Aug 6, 2018
@alanorozco alanorozco deleted the lightbox-sentinel branch August 6, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants