Pass referrer from the viewer #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Viewer override. | ||
| if (this.params_['referrer']) { | ||
| return this.params_['referrer']; |
There was a problem hiding this comment.
We should only trust this for trusted viewers. That is a concept we need to introduce.
Basically if the referrer/ancestorOrigins is google.com, we'd do this.
|
@cramforce PTAL |
| @@ -57,6 +58,7 @@ describe('dynamic classes are inserted at runtime', () => { | |||
| } | |||
| if (referrer !== undefined) { | |||
| overwrite(fixture.doc, 'referrer', referrer); | |||
There was a problem hiding this comment.
I think this line can be removed?
|
@cramforce PTAL. |
|
LGTM |
|
I will merge the new cases with taboola here as well. |
dvoytenko
force-pushed
the
viewer-ref
branch
3 times, most recently
from
7cb1db8
to
8747f1c
Compare
dvoytenko
added a commit
that referenced
this pull request
Feb 3, 2016
Pass referrer from the viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.