Doubleclick SRA - move to client-side exp selection #17191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevitzky
approved these changes
Aug 6, 2018
Codecov Report
@@ Coverage Diff @@
## master #17191 +/- ##
==========================================
- Coverage 77.87% 77.51% -0.37%
==========================================
Files 562 565 +3
Lines 41167 41423 +256
==========================================
+ Hits 32057 32107 +50
- Misses 9110 9316 +206
Continue to review full report at Codecov.
|
This was referenced Aug 7, 2018
This was referenced Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from SERP diversion to client-side, page level for simplicity and to get results across all AMP environments. Given there are now no SERP diverted experiments within Doubleclick impl, code has been removed.