New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Update Unruly loader URL #17235
✨Update Unruly loader URL #17235
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
030108c
to
3f99a34
Compare
CLAs look good, thanks! |
3f99a34
to
3176ceb
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
c6c03ad
to
99d269c
Compare
CLAs look good, thanks! |
c79c81e
to
5f4db35
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
5f4db35
to
3956b9b
Compare
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #17235 +/- ##
==========================================
+ Coverage 76.82% 77.8% +0.98%
==========================================
Files 561 562 +1
Lines 41140 41197 +57
==========================================
+ Hits 31606 32055 +449
+ Misses 9534 9142 -392
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@davidalk Thank you for the PR. LGTM and merged |
Thanks 👍 |
This change updates the url of the loader that the Unruly AMP tag will point to when loaded on the publishers page. The prefetch is also updated to point to the new loader.