Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Update Unruly loader URL #17235

Merged

Conversation

davidalk
Copy link
Contributor

@davidalk davidalk commented Aug 1, 2018

This change updates the url of the loader that the Unruly AMP tag will point to when loaded on the publishers page. The prefetch is also updated to point to the new loader.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ghost ghost force-pushed the feat/update-unruly-loader-url branch from 030108c to 3f99a34 Compare August 1, 2018 12:39
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 1, 2018
@ghost ghost force-pushed the feat/update-unruly-loader-url branch from 3f99a34 to 3176ceb Compare August 2, 2018 10:21
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 2, 2018
@ghost ghost force-pushed the feat/update-unruly-loader-url branch 2 times, most recently from c6c03ad to 99d269c Compare August 2, 2018 10:37
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 2, 2018
@ghost ghost force-pushed the feat/update-unruly-loader-url branch 2 times, most recently from c79c81e to 5f4db35 Compare August 2, 2018 13:10
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added cla: no and removed cla: yes labels Aug 2, 2018
@ghost ghost force-pushed the feat/update-unruly-loader-url branch from 5f4db35 to 3956b9b Compare August 2, 2018 13:11
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 2, 2018
@codecov-io
Copy link

Codecov Report

Merging #17235 into master will increase coverage by 0.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17235      +/-   ##
==========================================
+ Coverage   76.82%    77.8%   +0.98%     
==========================================
  Files         561      562       +1     
  Lines       41140    41197      +57     
==========================================
+ Hits        31606    32055     +449     
+ Misses       9534     9142     -392
Flag Coverage Δ
#integration_tests 36.08% <ø> (?)
#unit_tests 76.86% <ø> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8056da5...3956b9b. Read the comment docs.

@mrjoro mrjoro requested a review from zhouyx August 6, 2018 14:11
Copy link
Contributor

@zhouyx zhouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouyx zhouyx merged commit cc931f1 into ampproject:master Aug 13, 2018
@zhouyx
Copy link
Contributor

zhouyx commented Aug 13, 2018

@davidalk Thank you for the PR. LGTM and merged

@davidalk
Copy link
Contributor Author

Thanks 👍

Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants