🐛 Delay adding the ampshare fragment parameter until after the document is first visible

[ryjust]

When AMP CSI is enabled for CCT embedded documents, the hash fragment is updated by Chrome on click to include the click time. This process removes the ampshare parameter. The page becomes visible only after the fragment is updated so we need to delay adding the ampshare parameter until then.

[dreamofabear]

This should be viewer.whenFirstVisible(). If you change the test function from a closure to a generator function you can use yield.

it('should merge fragments within custom tab', function*() {
  ...
  yield viewer.whenFirstVisible();
  expect(windowApi...);
});

[ryjust]

Good suggestion! Much cleaner. Fixed!

[dreamofabear]

Thanks for contributing!

[dreamofabear]

Unit tests are unexpectedly failing on this test:

DESCRIBE => amp-a4a
  IT => should set height/width on iframe matching header value
    ✗ Error: Uncaught TypeError: win.getComputedStyle is not a function (node_modules/sinon/pkg/sinon.js:2538)

I'm getting the same error on #17128. The amp-a4a test probably implicitly depends on order of test execution. 😢 I'll dig into this and merge when ready.

/cc @rsimha

[rsimha]

The version of sinon we use is pretty old. I'm working on migrating to the latest version, which fixes some bugs, and has a more intuitive API and clearer error messages.

Edit: This is now done.

[dreamofabear]

@ryjust I fixed the issue in master. Can you merge latest and push?

[ryjust]

Everything is passing now. Thanks!