Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new amp-list attributes #17314

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Document new amp-list attributes #17314

merged 1 commit into from
Aug 6, 2018

Conversation

dreamofabear
Copy link

/to @aghassemi @bpaduch

@dreamofabear dreamofabear requested review from a user and aghassemi August 6, 2018 19:46
aghassemi
aghassemi approved these changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dreamofabear dreamofabear merged commit 5b612b3 into ampproject:master Aug 6, 2018
@dreamofabear dreamofabear deleted the list-new-attrs-docs branch August 6, 2018 22:15
kevinkassimo pushed a commit to kevinkassimo/amphtml that referenced this pull request Aug 9, 2018
@kevinkassimo
Document and attrs on amp-list. (ampproject#17314)
217533f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aghassemi aghassemi aghassemi approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dreamofabear @aghassemi @googlebot