Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ amp-image-slider test speedup #17392

Merged
merged 2 commits into from Aug 9, 2018
Merged

✅ amp-image-slider test speedup #17392

merged 2 commits into from Aug 9, 2018

Conversation

kevinkassimo
Copy link
Member

  • Use poll with timeout to replace timeout, ensures faster resolve on action complete

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 9, 2018
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 9, 2018
cathyxz
cathyxz reviewed Aug 9, 2018
View reviewed changes
extensions/amp-image-slider/0.1/test/integration/test-amp-image-slider.js Outdated
@@ -89,7 +89,7 @@ config.run('amp-image-slider', function() {
// layoutCallback is called
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest monitoring master red for flakes here and see if there are any platforms (e.g. Chrome on Windows) that need to be skipped due to the lower timeout.

@kevinkassimo kevinkassimo changed the title ✅amp-image-slider test speedup ✅ amp-image-slider test speedup Aug 9, 2018
@cathyxz cathyxz merged commit b5aef73 into ampproject:master Aug 9, 2018
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
@kevinkassimo @Enriqe
✅ amp-image-slider test speedup (ampproject#17392)
1cc5855 
* Speed up tests by using poll with timeout

* More lenient timeout with better error reporting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathyxz cathyxz cathyxz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinkassimo @googlebot @cathyxz