Fix undefined declrations #1740
Conversation
|
@dvoytenko LGTM |
|
Resource class has a couple I believe. Is there a lint check for this by any chance? |
|
@cramforce there is the |
|
|
||
| /** @private {!SizeList|null|undefined} */ | ||
| this.sizeList_; | ||
| this.sizeList_ = undefined; | ||
|
|
||
| /** @private {!SizeList|null|undefined} */ |
There was a problem hiding this comment.
couldnt we just assign null as the default then to simplify the types on these? (im ok w/ not changing these if it affects the actual code)
There was a problem hiding this comment.
nvm, looks like we explicitly check for undefined in comparisons.
There was a problem hiding this comment.
correct, undefined is a meaningful value here.
|
@cramforce looks like i only missed one. |
|
@erwinmombay ptal. let's push this through and then feel free to enable linter. |
|
@dvoytenko LGTM |
/cc @cramforce