Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 amp-image-slider remove webkit tap grayish color #17413

Merged
merged 1 commit into from Aug 10, 2018

Conversation

kevinkassimo
Copy link
Member

@kevinkassimo kevinkassimo commented Aug 10, 2018

  • Set webkit highlight color to transparent

Solution described here:
https://css-tricks.com/snippets/css/remove-gray-highlight-when-tapping-links-in-mobile-safari/

Copy link
Contributor

@nainar nainar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding the reference to the StackOverflow (or wherever) solution. So that people searching this can have some context. Add that to the commit description? LGTM otherwise.

Remove the grayish mask created when pressing an area on Safari for a
very short while, by setting the color transparent.

Solution described here:
https://css-tricks.com/snippets/css/remove-gray-highlight-when-tapping-links-in-mobile-safari/
@kevinkassimo
Copy link
Member Author

@nainar Added in commit message body.

@nainar
Copy link
Contributor

nainar commented Aug 10, 2018

Perfect message me here or offline when this is ready to merge! :)

@kevinkassimo
Copy link
Member Author

@nainar finally pass Travis after outage. Could be merged now

@nainar nainar merged commit 6e08dc9 into ampproject:master Aug 10, 2018
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
Remove the grayish mask created when pressing an area on Safari for a
very short while, by setting the color transparent.

Solution described here:
https://css-tricks.com/snippets/css/remove-gray-highlight-when-tapping-links-in-mobile-safari/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants