Skip flaky slider test #17556
Merged
Skip flaky slider test #17556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @rsimha |
rsimha
approved these changes
Aug 16, 2018
| @@ -505,7 +505,7 @@ config.run('amp-image-slider', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should show hint again on scroll back and into viewport', () => { | |||
| it.skip('should show hint again on scroll back and into viewport', () => { | |||
There was a problem hiding this comment.
Add a TODO, assigned to @kevinkassimo and tagged with #17543
kevinkassimo
approved these changes
Aug 16, 2018
|
This is flaky on Thanks for skipping. |
|
Thanks for skipping! We're experimenting with |
|
Sorry for the issue, I believe scrolling was not performing correctly. Trying to refactor it in #17543 |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* skip * todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are being refactored in #17543, but this is a stopgap.