✨ Version lock CSS #17562
Merged
✨ Version lock CSS #17562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that when an AMP doc is Server Side Rendered (by inlining the v0.css or any extension's CSS into the doc), the inlined styles are exactly what the JS expects. This eliminates the possibility of version skew for pages that use cached v0.js but inlined CSS.
cramforce
requested changes
Aug 16, 2018
src/style-installer.js
Outdated
| @@ -131,6 +131,7 @@ export function installStylesLegacy( | |||
| * @return {!Element} | |||
| */ | |||
| function insertStyleElement(cssRoot, cssText, isRuntimeCss, ext) { | |||
| cssText = cssText.trim(); | |||
There was a problem hiding this comment.
Do we need to trim?
Because if we do we should make it so that we don't have to.
There was a problem hiding this comment.
No, AMP Cache doesn't.
But, I'm concerned with pub SSR generating:
<style>
/* whitespace *//* CSS */
/* whitespace */</style>If they do that, I didn't want to override the CSS and cause a reparse. And if we allow it to remain, we would need to strip the value when installing CSS into child windows.
There was a problem hiding this comment.
We should consider that invalid for SSR. @honeybadgerdontcare
Let's avoid the trimming here. It may increase memory usage.
There was a problem hiding this comment.
Removed the trimming.
There was a problem hiding this comment.
Agreed, we can assist with pub SSR generation. Filed b/112736946 and b/112737536.
src/style-installer.js
Outdated
| @@ -146,6 +147,9 @@ function insertStyleElement(cssRoot, cssText, isRuntimeCss, ext) { | |||
| if (key) { | |||
| const existing = getExistingStyleElement(cssRoot, styleMap, key); | |||
| if (existing) { | |||
| if (existing.textContent.trim() !== cssText) { | |||
cramforce
approved these changes
Aug 17, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Version lock CSS This ensures that when an AMP doc is Server Side Rendered (by inlining the v0.css or any extension's CSS into the doc), the inlined styles are exactly what the JS expects. This eliminates the possibility of version skew for pages that use cached v0.js but inlined CSS. * Tests * Don't trim * Don't trim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that when an AMP doc is Server Side Rendered (by inlining
the v0.css or any extension's CSS into the doc), the inlined styles are
exactly what the JS expects. This eliminates the possibility of version
skew for pages that use cached v0.js but inlined CSS.