馃悰 Fix scrollTo with layers
#17563
Merged
馃悰 Fix scrollTo with layers
#17563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Aug 16, 2018
| newScrollTop = elementRect.top + offset + curScrollTop; | ||
| } else { | ||
| const calculatedScrollTop = elementRect.top - this.paddingTop_ + offset; | ||
| newScrollTop = Math.max(0, calculatedScrollTop); |
There was a problem hiding this comment.
We should do this same Math.max for Layers as well. Shouldn't happen in practice, but better to be safe.
jridgewell
approved these changes
Aug 17, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Fix scrollTo with layers * Add Math.max
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With layers, both
newScrollTopandcurScrollTopshould be relative to parent'sscrollTop.Thanks @jridgewell !