Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Add many more choices for STAMP ads enum #17579

Merged
merged 1 commit into from Aug 21, 2018
Merged

✨Add many more choices for STAMP ads enum #17579

merged 1 commit into from Aug 21, 2018

Conversation

calebcordry
Copy link
Member

Looks like even the longest string Watch Episode will fit.

localhost_8000_examples_amp-story-auto-ads amp html iphone x

@calebcordry
Copy link
Member Author

cc/ @jasti

@lannka
Copy link
Contributor

lannka commented Aug 17, 2018

@calebcordry English is fine. What about other languages such as Germany?

@calebcordry
Copy link
Member Author

You are right, German may be too long. Should we:

  1. Add these in english now, and possibly have only a subset available later in other languages
  2. Wait until we figure out internationalization and then introduce them all at once

@lannka
Copy link
Contributor

lannka commented Aug 20, 2018

2 sounds good.

@calebcordry calebcordry merged commit b53e322 into ampproject:master Aug 21, 2018
@calebcordry calebcordry deleted the all-the-enums branch August 21, 2018 17:12
@calebcordry
Copy link
Member Author

Talked offline. Went with 1.

Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
@calebcordry @Enriqe
add options (ampproject#17579)
ca50f42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebcordry @lannka @googlebot