Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Survey and fix prerenderAllowed() usage #17586

Merged
merged 4 commits into from Aug 20, 2018
Merged

Survey and fix prerenderAllowed() usage #17586

merged 4 commits into from Aug 20, 2018

Conversation

dreamofabear
Copy link

  • Avoid inspecting the element in the constructor (instead use firstAttachedCallback)
  • Allow amp-layout to be built in prerender mode
  • Fix noprerender detection in amp-img

/to @aghassemi @gmajoulet

aghassemi
aghassemi approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dreamofabear dreamofabear merged commit 93517ed into ampproject:master Aug 20, 2018
@dreamofabear dreamofabear deleted the prerender-survey branch August 20, 2018 19:09
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
@Enriqe
Survey and fix prerenderAllowed() usage (ampproject#17586)
138f0b2 
* Survey and fix prerenderAllowed() usage.

* Fix test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

@aghassemi aghassemi aghassemi approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dreamofabear @gmajoulet @aghassemi @googlebot