amp-date-countdown: migrated getAttributes from constructor to buildCallback #17656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @leonalicious |
cathyxz
approved these changes
Aug 22, 2018
|
@aghassemi @cathyxz may i know when will this PR get merged into master branch please ? |
|
@aghassemi @cathyxz may i know when will this PR get merged into master branch please ? |
|
@leonalicious apologies, ran into some lint issue then was our of office. Will merge it today. |
|
@leonalicious there were some type issues with the PR which I fixed but now unit tests are failing as they are not compatible with the move from |
|
Never mind, managed to find a fix for it. Merged. Sorry about the delay |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…allback (ampproject#17656) * amp-date-countdown: migrated getAttributes from constructor to buildCallback * lint * define the types in constructor * set end-date in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of #17622 by @leonalicious
Fixes #17596
amp-date-countdownwill have issue of getting the attributes from DOM. We should have writtenlist of elements which are responsible of getting attributes from DOM, such as
this.element.getAttribute('end-date')inbuildCallback()instead ofconstructor()