Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

鉁ㄢ湪馃悰鉁ㄢ湪 Don't disconnect while debugging tests #17674

Merged
merged 2 commits into from Aug 23, 2018

Conversation

jridgewell
Copy link
Contributor

How many of you have had your browser window killed while you were
debugging a test? Not anymore...

How many of you have had your browser window killed while you were
debugging a test? Not anymore...
browserNoActivityTimeout: 4 * 60 * 1000,
captureTimeout: 4 * 60 * 1000,
failOnEmptyTestSuite: false,

// IF YOU CHANGE THIS, DEBUGGING WILL RANDOMLY KILL THE BROWSER

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槅

Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憦

@jridgewell jridgewell added this to To do in Make Malte, Dima, Justin Happy via automation Aug 23, 2018
@jridgewell jridgewell merged commit ee9673e into ampproject:master Aug 23, 2018
Make Malte, Dima, Justin Happy automation moved this from To do to Done Aug 23, 2018
@jridgewell jridgewell deleted the karma-debugging branch August 23, 2018 03:16
@calebcordry
Copy link
Member

YES! This has been annoying me for quite a while. Thanks @jridgewell

Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
* 鉁ㄢ湪馃悰鉁ㄢ湪 Don't disconnect while debugging tests

How many of you have had your browser window killed while you were
debugging a test? Not anymore...

* Update karma.conf.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants