Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-bind: Send 'bindReady' to viewer on init #17737

Merged
merged 4 commits into from Aug 27, 2018

Conversation

dreamofabear
Copy link

b/112498807#comment7

/to @alabiaga

@dreamofabear dreamofabear added the Externally Tracked Tracked by Google or other parties label Aug 27, 2018
Copy link
Contributor

@alabiaga alabiaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a github issue we can reference for this fix. The one in desc is internal.

@dreamofabear
Copy link
Author

Nope. :) Not all pull requests need a tracking issue. This one is pretty straightforward.

@dreamofabear dreamofabear merged commit b6a8cd1 into ampproject:master Aug 27, 2018
@dreamofabear dreamofabear deleted the bind-ready branch August 27, 2018 22:30
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Aug 29, 2018
* Send 'bindReady' on init.

* Fix types.

* Whitelist usage in presubmit.

* Fix test. Sorry.
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
* Send 'bindReady' on init.

* Fix types.

* Whitelist usage in presubmit.

* Fix test. Sorry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Externally Tracked Tracked by Google or other parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants