Inabox host script - Cannot read property \'top\' of undefined #17749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkaufman
approved these changes
Aug 28, 2018
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Aug 29, 2018
…oject#17749) * initial commit * lint fix
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
…oject#17749) * initial commit * lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inabox host script throwing "Uncaught TypeError: Cannot read property 'top' of undefined" likely due to event source being undefined due to underlying frame being destroyed between when message was sent and when it was processed. Ensure that underlying code tolerates undefined/null window and that any postmessage processing is wrapped in try/catch (previously only queued events were wrapped).