馃悰Don't fire STAMP ads analytics if no ads #17756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @gmajoulet who may be working on the same issue. |
lannka
requested changes
Aug 28, 2018
| @@ -546,6 +546,13 @@ export class AmpStoryAutoAds extends AMP.BaseElement { | |||
| this.uniquePageIds_[pageId] = true; | |||
| } | |||
|
|
|||
| if (this.adPagesCreated_ === 0) { | |||
There was a problem hiding this comment.
we should move this check together with the uniquePagesCount_ logic to the top of this method.
| if (this.adPagesCreated_ === 0) { | ||
| // This is protection against us running our placement algorithm in a | ||
| // story where no ads have been created. Most likely because INI_LOAD on | ||
| // the story was fired very late, or not at all. |
There was a problem hiding this comment.
Most likely because INI_LOAD on the story hasn't been fired yet.
|
I wasn't 100% sure where you wanted to register |
lannka
approved these changes
Aug 29, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* exit if no ads * move order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some analytics that were triggered by listening to page changes would break if no ad pages existed. This appears to be caused by
INI_LOADon the story firing very late or not at all (will file separate issue to investigate)Closes #17593