Inabox: Support layers #17823
Merged
Inabox: Support layers #17823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Layers returns scroll relative layout boxes.
jridgewell
force-pushed
the
inabox-layers
branch
from
354bbf6
to
62b4e36
Compare
lannka
reviewed
Aug 31, 2018
| @@ -177,9 +180,14 @@ export class ViewportBindingInabox { | |||
| /** @override */ | |||
| getLayoutRect(el) { | |||
| const b = el./*OK*/getBoundingClientRect(); | |||
| let {left, top} = b; | |||
| if (this.useLayers_) { | |||
| left -= this.viewportRect_.left; | |||
There was a problem hiding this comment.
can you explain why do we offset with viewportRect?
There was a problem hiding this comment.
oh, is layer's coordinate system relative to viewport instead of doc?
There was a problem hiding this comment.
Yes, Layer’s rects should exactly match getBoundingClientRect (with rounding) in every circumstance.
In this case, we need to factor in that the is relative to a viewport in a parent document.
lannka
approved these changes
Aug 31, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Inabox: Support layers Layers returns scroll relative layout boxes. * Add import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layers returns scroll relative layout boxes.
Fixes #17825